puppet-nginx refactor to class/arguments #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vhosts defined Description: When running first time from scratch, if class was included without any setup at all and with sane defaults, in debian squeeze generates an error when trying to collect non existant vhosts, because cat complains that can not expand * because there are no files. Changed: Added unless to check that at least there is a file in nginx.d by testing it can expand.
…new structure, backwards compatible Defaults are set inside params, nginx class will set default and send it from local var to nginx::config, so even when there is no need for set default values on nginx::config, in case someone already using this module it's for some reason calling directly nginx::config, to avoid breaking anything defaults are set inside nginx::config too.
jfryman
added a commit
that referenced
this pull request
Oct 2, 2012
puppet-nginx refactor to class/arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits (hopefully) will add the first arguments to puppet-nginx and hopefully will set the basic idea for anyone to help refactor puppet-nginx make sure of not breaking current users of puppet-nginx.
The idea is that nothing should be trusted and everything must have a sane default value, arguments MUST have defaults from params.pp set on main class as well as for any subclass that needs it, so no matter no one should be calling subclasses (eg nginx::config) by themselves, we should set a default for it too, as someone may be calling it and not setting a default in the subclass call will break his configuration.