Reintegrate jfryman/puppet-nginx#331 (upstream exports/collections) #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- resurrecting voxpupuli#331 from @rainopik - update (concat/stdlib) dependency version requirements based on current usage - fix upstream tests to work with rainopik's changes in what was voxpupuli#331
This was referenced Jun 21, 2014
Closed
|
Tried this on my setup, seems ok to me. |
|
Just a note to say that I'll merge this into my fork in a bit and give a go - but it'll probably be Sunday Evening UK time that I do that. The change itself looks sane. |
|
After upgrading my concat to 1.1.0 from 1.0.2 it works as advertised using Ubuntu 12.04, and Puppet 3.5.1. Great work @rabbitt |
|
🤘 |
jfryman
pushed a commit
that referenced
this pull request
Jun 24, 2014
Reintegrate #331 (upstream exports/collections)
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Reintegrate voxpupuli#331 (upstream exports/collections)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p.s. Might I suggest that, prior to merging, anyone whom has any opinions on this (@leepa, @jfryman, @rainopik, @zxjinn, ??) take a look and reflect on whether or not this is at a point where it's ready?