Allow using $http_cfg_append with list of lists

[motiejus]

Since 5a9767d we are not able to use list of lists in $http_cfg_append.

It should be possible to include a list of lists in order to have duplicate configuration keys, like:

nginx::http_cfg_append:
    - [include, /etc/nginx/vhosts/*.ngx]
    - [include, /etc/nginx/vhosts/*/*.ngx]

Discussion:
I reverted the validation, which is sub-optimal. However, ideally, the patch should look like:

-    validate_hash($http_cfg_append)
+    validate_hash($http_cfg_append) || validate_array($http_cfg_append)

but since both functions raise Puppet::Error, there is no way that I know of to make such a conditional happen.

[jfryman]

Seems like you could do one of these...

if !is_hash($http_cfg_append) or !is_array($http_cfg_append) {
  fail('$http_cfg_append must be either a hash or array')
}

[motiejus]

Thanks, fixed!

[jfryman]

👍

[Billiam]

Won't that logic always fail for non-true http_cfg_append values, since a given value will either: not be a hash or not be an array?

[motiejus]

I am not following you. Can you provide an exmaple?