-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nginx_version fact #753
Conversation
Please add a test for this. Can use puppetlabs/puppetlabs-mysql@3ce8ad3 as a template. |
@3flex done. Thanks. |
Hmm. I'm not familiar with testing this particular fact type. Let me look into it; the test fails, but the fact works. |
OK, I got it. I forgot to stub :which. |
Looks good. Hopefully obvious, but did you confirm it works on a real machine? |
Using it in production now, actually.
|
@jyaworski I'm proposing this be reverted (see #760) because it's not supported by earlier versions of Facter which are still supported by this module. Are you able to make a version that is compatible back to Facter 1.7? If so, please submit a new PR. Thanks! |
Add nginx_version fact
No description provided.