Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx_version fact #753

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Add nginx_version fact #753

merged 1 commit into from
Feb 1, 2016

Conversation

jyaworski
Copy link
Member

No description provided.

@3flex
Copy link
Contributor

3flex commented Jan 29, 2016

Please add a test for this. Can use puppetlabs/puppetlabs-mysql@3ce8ad3 as a template.

@jyaworski jyaworski changed the title Add nginx_version fact [WIP] Add nginx_version fact Jan 29, 2016
@jyaworski
Copy link
Member Author

@3flex done. Thanks.

@jyaworski jyaworski changed the title [WIP] Add nginx_version fact Add nginx_version fact Jan 29, 2016
@jyaworski
Copy link
Member Author

Hmm. I'm not familiar with testing this particular fact type. Let me look into it; the test fails, but the fact works.

@jyaworski
Copy link
Member Author

OK, I got it. I forgot to stub :which.

@3flex
Copy link
Contributor

3flex commented Jan 29, 2016

Looks good. Hopefully obvious, but did you confirm it works on a real machine?

@jyaworski
Copy link
Member Author

Using it in production now, actually.

On Jan 29, 2016, at 4:44 PM, Matthew Haughton notifications@github.com wrote:

Looks good. Hopefully obvious, but did you confirm it works on a real machine?


Reply to this email directly or view it on GitHub.

3flex added a commit that referenced this pull request Feb 1, 2016
@3flex 3flex merged commit f544dfe into voxpupuli:master Feb 1, 2016
@jyaworski jyaworski deleted the add_nginx_version_fact branch February 1, 2016 16:58
@3flex
Copy link
Contributor

3flex commented Feb 4, 2016

@jyaworski I'm proposing this be reverted (see #760) because it's not supported by earlier versions of Facter which are still supported by this module.

Are you able to make a version that is compatible back to Facter 1.7? If so, please submit a new PR. Thanks!

Slm0n87 pushed a commit to Slm0n87/puppet-nginx that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants