Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manage_service parameter #817

Merged
merged 1 commit into from
Jun 23, 2016
Merged

Add manage_service parameter #817

merged 1 commit into from
Jun 23, 2016

Conversation

iain-buclaw-sociomantic
Copy link
Contributor

Puppet managing the service is not desirable in every environment.

Use ?w=1 to omit whitespace changes.

3flex
3flex reviewed Jun 23, 2016
View reviewed changes
manifests/service.pp
flags => $service_flags,
hasstatus => true,
hasrestart => true,
if $manage_service == true {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use if $manage_service {, it's a little cleaner

@3flex
Copy link
Contributor

3flex commented Jun 23, 2016

Thanks for the contribution!

I've added some notes inline. Tests for this functionality would also be very very useful, take a look at /spec/classes/service_spec.rb and see if you're able to add a new test. It would be similar to adding a block like this https://github.com/jfryman/puppet-nginx/blob/955cdc7aac744141c8be82e1f4b9e7efbbb9dadb/spec/classes/service_spec.rb#L24-L42

@3flex 3flex added the enhancement New feature or request label Jun 23, 2016
@iain-buclaw-sociomantic
Copy link
Contributor Author

Added test in service_spec.rb, and made changes as per notes. Rebased it against master also.

I hope the test is fine, I wasn't able to check locally.

@3flex
Copy link
Contributor

3flex commented Jun 23, 2016

Looks solid, thank you!

@3flex 3flex merged commit 80c13af into voxpupuli:master Jun 23, 2016
@iain-buclaw-sociomantic
Copy link
Contributor Author

Thanks!

@iain-buclaw-sociomantic iain-buclaw-sociomantic deleted the manageservice branch June 23, 2016 13:38
Slm0n87 pushed a commit to Slm0n87/puppet-nginx that referenced this pull request Mar 7, 2019
@3flex
Merge pull request voxpupuli#817 from iain-buclaw-sociomantic/manages…
14f9b76 
…ervice

Add manage_service parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iain-buclaw-sociomantic @3flex