Allow locations with try_files only #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already possible through location_custom_cfg with a manifest
that looks like:
nginx::resource::location { 'location name':
location => '/',
vhost => 'any vhost',
location_custom_cfg => {
'try_files' => '$uri $uri/ @rewrite',
}
}
This change simplifies the part by allowing to use the try_files
directive on its own (without only in combination with, e.g., www_root):
nginx::resource::location { 'location name':
location => '/',
vhost => 'any vhost',
try_files' => [ '$uri', '$uri/', '@rewrite' ],
}
That looks a bit better as know the user doesn't need to think about,
if he can use try_files or need to use location_custom_cfg in the current
context, anymore.
fixes voxpupuli#470
This was referenced Oct 12, 2016
Closed
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Allow locations with try_files only
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Allow locations with try_files only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already possible through location_custom_cfg with a manifest
that looks like:
nginx::resource::location { 'location name':
location => '/',
vhost => 'any vhost',
location_custom_cfg => {
'try_files' => '$uri $uri/ @rewrite',
}
}
This change simplifies the part by allowing to use the try_files
directive on its own (without only in combination with, e.g., www_root):
nginx::resource::location { 'location name':
location => '/',
vhost => 'any vhost',
try_files' => [ '$uri', '$uri/', '@rewrite' ],
}
That looks a bit better as know the user doesn't need to think about,
if he can use try_files or need to use location_custom_cfg in the current
context, anymore.
fixes #470