Add vox pupuli's configuration #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3flex
force-pushed
the
voxpupuli
branch
4 times, most recently
from
6e0490f to
3408602
Compare
3flex
force-pushed
the
voxpupuli
branch
5 times, most recently
from
5c23b9d to
8a2e61a
Compare
3flex
force-pushed
the
voxpupuli
branch
2 times, most recently
from
540c3da to
bc3f5c4
Compare
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Add vox pupuli's configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wholesale import of vox pupuli's default modulesync configuration from https://github.com/voxpupuli/modulesync_config, with one modification to improve the behaviour of loading facts that will hopefully be merged upstream (voxpupuli/modulesync_config#207).
Based on this new configuration the following improvements have been made:
If this module is migrated there, this will ensure a smooth transition. If not, we still get the improvements above, and hopefully cleaner code going forward. The STRICT_VARIABLES check was on my to do list for a long time, so very happy to have fixed it!