Add additional config variables with default values (update of #693) #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror pages in vhosts, supporting proxy_http_version within locations
wyardley
changed the title
|
$error_pages should have defaulted to 'undef' instead of {}. |
|
@pschichtel: We have a few PRs in progress that should go out first, but shooting to cut a Forge release pretty soon. It'll be a big one, with a few breaking changes. Hoping to get this out within the next week or so. |
|
Cool, thanks for the update! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Add additional config variables with default values (update of voxpupuli#693)
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Add additional config variables with default values (update of voxpupuli#693)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of @victorgp's #693 that rebases against current master, and adds tests for the new parameters (the two reasons that PR seems to have been stalled).
I also removed what appear to be a few duplicate tests (let me know if I'm wrong), and realigned dashes in one section of the docs, though mostly tried not to change too much formatting.
I squashed his and my commits, though left attribution for @victorgp's original commit. I don't think I can commit back to the PR since I'm not in the org, but let me know if that's the preferred way to do it (vs. submitting a new PR).
I tried to follow the existing conventions, but It would be great if someone could review my changes to the tests, as well as review the formatting and ordering of directives within nginx.conf.