Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure acceptance tests on docker on travis #885

Merged
merged 4 commits into from
Sep 29, 2016

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Sep 24, 2016

Depends on voxpupuli/modulesync_config#230

It's safe to merge without that change and a new module sync, but the changes in .sync.yml would be redundant.

@petems
Copy link
Member

petems commented Sep 29, 2016

Merging as this is good for Vagrant VM's as well as Docker. The discussion around enabling PR's for Travis is a larger one that requires consensus.

This is Safe, Small and Sensible so merging after a local test with a Vagrant box:

Finished in 1 minute 40.02 seconds (files took 2 minutes 7 seconds to load)
43 examples, 0 failures

@petems petems merged commit 171008c into master Sep 29, 2016
@@ -59,6 +59,16 @@
aIZ8kxsBjLvpi9KQTHi7Wl6Sw3ecoYdKy+2P8S5xOIpWjs8XVmOWf7Tq1+9KPv3z
HLw/FDCzntkdq3G4em15CdFlO9BTY4HXiHU=
-----END CERTIFICATE-----" > /tmp/blah.cert'

#--- START SELINUX WORKAROUND ---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just dropping the certs into /etc in the first place, and then just using /etc/blah.{crt,key} as the path? Then we don't have to use this whole workaround at all, assuming selinux allows those files to be in /etc
Or symlink /etc/pki to /etc/ssl early in the process for Debian?

I also see some discussion about disabling SELinux with Beaker here: https://bugzilla.redhat.com/show_bug.cgi?id=1074384

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusingly, that is a different Beaker testing project, run by RedHat 😄 https://beaker-project.org/

@bastelfreak bastelfreak deleted the configure_docker_on_travis branch September 29, 2016 21:29
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
…ravis

Configure acceptance tests on docker on travis
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
…ravis

Configure acceptance tests on docker on travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants