Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more test and docs fixes for acceptance tests for CentOS / Passenger #886

Merged
merged 1 commit into from
Sep 29, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/quickstart.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class{'nginx':
package_source => 'nginx-mainline'
}
```
The choices here are `nginx-stable` (the current 'production' level release), `nginx-mainline` (where active development is occuring), as well as `passenger` - you can read a full explanation of the differences [here][nginxpackages]. `passenger` will install Phusion Passenger, as well as their version of nginx built with Passenger support. Keep in mind that changing `package_source` may require some manual intervention if you change this setting after initial configuration. On CentOS 6 / RHEL 6, there is a soft dependency on EPEL (GeoIP package won't install without it).
The choices here are `nginx-stable` (the current 'production' level release), `nginx-mainline` (where active development is occuring), as well as `passenger` - you can read a full explanation of the differences [here][nginxpackages]. `passenger` will install Phusion Passenger, as well as their version of nginx built with Passenger support. Keep in mind that changing `package_source` may require some manual intervention if you change this setting after initial configuration. On CentOS / RHEL, there is a soft dependency on EPEL for this (i.e., the module doesn't configure EPEL for you, but will fail if you don't have it).

### Creating Your First Virtual Host

Expand Down
6 changes: 3 additions & 3 deletions spec/acceptance/nginx_vhost_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class { 'nginx': }
end

it 'answers to www.puppetlabs.com without error' do
shell('/usr/bin/curl http://www.puppetlabs.com:80') do |r|
shell('/usr/bin/curl --fail http://www.puppetlabs.com:80') do |r|
expect(r.exit_code).to be_zero
end
end
Expand Down Expand Up @@ -90,7 +90,7 @@ class { 'nginx': }
end

it 'answers to http://www.puppetlabs.com without error' do
shell('/usr/bin/curl http://www.puppetlabs.com:80') do |r|
shell('/usr/bin/curl --fail http://www.puppetlabs.com:80') do |r|
expect(r.exit_code).to eq(0)
end
end
Expand All @@ -104,7 +104,7 @@ class { 'nginx': }

it 'answers to https://www.puppetlabs.com without error' do
# use --insecure because it's a self-signed cert
shell('/usr/bin/curl --insecure https://www.puppetlabs.com:443') do |r|
shell('/usr/bin/curl --fail --insecure https://www.puppetlabs.com:443') do |r|
expect(r.exit_code).to eq(0)
end
end
Expand Down
6 changes: 2 additions & 4 deletions spec/spec_helper_acceptance.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@
if fact('osfamily') == 'Debian'
on host, puppet('module', 'install', 'puppetlabs-apt'), acceptable_exit_codes: [0, 1]
elsif fact('osfamily') == 'RedHat'
# Cheat to work around soft dep on EPEL for CentOS / EL 6
if fact_on(host, 'operatingsystemmajrelease') == '6'
install_package(host, 'epel-release')
end
# Soft dep on epel for Passenger
install_package(host, 'epel-release')
end
on host, puppet('module', 'install', 'puppetlabs-stdlib'), acceptable_exit_codes: [0, 1]
on host, puppet('module', 'install', 'puppetlabs-concat'), acceptable_exit_codes: [0, 1]
Expand Down