Possible solution for Issue #71

[hingstarne]

Hi,

i added a mechanism that allows the user to choose the debian package repositories.
At the moment its default to use the nginx upstream packages. With the patch you can choose between nginx, dotdeb and debian default packages.
Its tested on Squeeze and Wheezy with all the 3 providers.
Hope you like it.
Best Regards
Arne

[abraham1901]

puppet-lint?

[abraham1901]

Hello,
Thanks for this code.
You check this change on ubuntu?

[hingstarne]

With Ubuntu you cannot use dotdeb packages they are officialy for debian only.
I added some version strings for ubuntu in my changes but i need to rewrite the proxy.conf.erb.
The old versions of nginx in squeeze or jaunty do not support proxy_http_version as a parameter.
I will fix this and send a pull request.

[hingstarne]

I tested it under lucid, precise and squeeze, wheezy
It should allow you to set debian / ubuntu original packages with

class {'nginx':
        nx_debian_repository    => 'debian';
    }

Hope this helps you out

[jfryman]

I've been waffling on this PR mostly because I am debating whether it is the job of this module to manage package repositories or if that responsibility should be delegated to some site-specific manifests.

This would also mean I rip out the current RH code that sets up the Yum repos as well.

I'd ❤️ input here from interested parties.

[hingstarne]

Hi,
to be honest this would mean to pull out all of the package repository configuration ( except maybe for the package name), for all distros and have external dependencies like puppetlabs-apt or similar for other distros.
Did i understand you correct with this?

[jfryman]

@hingstarne Yes, and more. I would certainly like to get rid of this mess (https://github.com/jfryman/puppet-nginx/blob/master/manifests/package/debian.pp#L26-L49) and use puppetlabs-apt to manage the apt repositories.

Even more than that, I think that this module should have the responsibility for managing the package resource (name/version), and we can set intelligent defaults in params for each distro (like we do today), but also allow for a new package name to get passed into nginx::package in the event someone else has rolled their own packages and use a non-standard name (It happens). We could keep the yum and apt declarations, but they'd have to be manually included by a sysadmin somewhere in a node manifest, not as part of Class[nginx].

TL;DR: Make it the sysadmin's responsibility to include what package repositories a package comes from external to this module. Include some defaults, but don't make them mandatory.

[elmerfud]

@jfryman I'll count myself as an interested party. It's my preference that package repository setup be handled outside this module, or have it be something that can be enabled/disabled optionally.

In our organization we run private repository mirrors for almost all packages that our systems use. Our production systems can't directly reach public repositories and must either use our mirror, or go through a proxy.

[vrillusions]

@jfryman 👍 to having it managed outside this. As an example I was going to start looking into setting up a new config parameter that would let you choose between stable and mainline branches. Obviously if that task is just ripped out of this module I can instead have my site module set the repo however I want.

[jfryman]

/cc #146 #144

[jfryman]

Way old. Thanks for taking a pass at this... going to revisit when 🕐 allows. Please reopen and rebase if you wanna take another pass at this.