Prevent custom fact from complaining when openresty is installed #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a modified nginx (for instance openresty: http://openresty.org/en/) is installed.
|
Merging since @alexjfisher already approved in #890 |
|
This didn't address #890 (comment)? |
|
@3flex: Unless I'm missing something, I think @shoikan already resolved it earlier, it's a [2], not a [1] in: There was no test for it, though, which seems bad. I opened #911. If you think the regex needs to be fixed, let me know in there. |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Prevent custom fact from complaining when openresty is installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #890 that should apply to current master and preserve original authorship of commit.
@shoikan @alexjfisher
(I tried making a pull request against the pull request, but because that master is now out of date again, it didn't work).