Use default ssl_protocols for ssl mailhosts #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on voxpupuli#909. It also adds a test for the $ssl_ciphers parameter.
jyaworski
reviewed
Oct 17, 2016
| @@ -101,6 +103,7 @@ | |||
| if ($ssl_cert != undef) { | |||
| validate_string($ssl_cert) | |||
| } | |||
| validate_string($ssl_protocols) | |||
There was a problem hiding this comment.
I feel blah about having this as a string rather than an array, but I guess there's a precedent.
There was a problem hiding this comment.
I agree an array is better but this is in line with the existing config and by the principle of least surprise I think this is the better choice.
dol
reviewed
Oct 21, 2016
| @@ -30,7 +30,7 @@ server { | |||
| ssl_certificate_key <%= @ssl_key %>; | |||
| ssl_session_timeout 5m; | |||
|
|
|||
| ssl_protocols TLSv1; | |||
| ssl_protocols <%= @ssl_protocols %>; | |||
There was a problem hiding this comment.
The same change applies to the puppet-nginx/templates/mailhost/mailhost.erb file. Because the SSL part of the two templates are equal I used to combine the two into one file that gets included. I'll fix the missing variable in my PR #769.
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Use default ssl_protocols for ssl mailhosts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #909. It also adds a test for the $ssl_ciphers parameter.
I haven't had the time yet to verify this on a real system.