Allow setting $daemon to "on" or "off" (defaults to unset) #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prove usability for Docker
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Allow setting $daemon to "on" or "off" (defaults to unset)
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Allow setting $daemon to "on" or "off" (defaults to unset)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this in @garethr's talk -- currently, there's no way without using a custom config to turn
$daemonoff. Obviously, this is something that probably wasn't useful to most people before, but becomes a lot more useful if used along with containerization.This doesn't change the existing behavior, but allows it to be explicitly set to 'on' or 'off' via a parameter (this is still just the string on / off; #457 addresses possibly allowing booleans to work instead or in addition to).
Let me know if these tests look reasonable.