Add 'require' for parent dir of upstream, map, and geo configs as wel… #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR is just fine and has already been tested via #942. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
…le_requires Add 'require' for parent dir of upstream, map, and geo configs as wel…
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…le_requires Add 'require' for parent dir of upstream, map, and geo configs as wel…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should come a lot closer to resolving #942.
Few questions:
$conf_dirwithin the resource manifests (since we've got$::nginx::config::conf_dir? Or is this fine?$::nginx::config, but decided to leave it this way, but open to discussion. Upstream and vhost specifically differs depending on settings like$confd_only, and some of the other resources have their own directories, likeconf.mail.d, so I'm not sure if making it more generic is worth the effort.