Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora 38 & 39 support #81

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

Valantin
Copy link
Contributor

@Valantin Valantin commented Mar 13, 2024

Pull Request (PR) description

Add fedora 38 and 39 to supported OS and remove the older one

This Pull Request (PR) fixes the following issues

@TheMeier
Copy link
Contributor

TheMeier commented Mar 13, 2024

Uhm is it really worth tracking fedora with two release per year? 31 and 32 are already EOL. 39 is current

@Valantin
Copy link
Contributor Author

ops, I've read the info from the voxpupuli page forgetting it wasn't updated.
What do you propose? if not in the metadata it not install open-vm-tools

@Valantin Valantin force-pushed the add-fedora32 branch 2 times, most recently from 93dc8e3 to 6199a5a Compare March 13, 2024 15:30
@Valantin Valantin changed the title Add Fedora 31 and 32 to supported OS Add Fedora 38 and 39 to supported OS Mar 13, 2024
@Valantin Valantin changed the title Add Fedora 38 and 39 to supported OS Update Fedora version in supported OS Mar 18, 2024
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it's good to keep in CI.

You can also drop the operatingsystemrelease part and make it versionless. AFAIK that should be interpreted as "all versions". Not sure how our CI deals with it. Perhaps we should apply some filter to it to check the EOL data we have.

I'd go with this in the short term.

@bastelfreak bastelfreak changed the title Update Fedora version in supported OS Add Fedora 38 & 39 support Mar 28, 2024
@bastelfreak bastelfreak merged commit dfd624b into voxpupuli:master Mar 28, 2024
34 checks passed
@Valantin Valantin deleted the add-fedora32 branch March 29, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants