feature (server): add nobind parameter support. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the server is running in client mode, you have to specify a fixed port for every vpn server. Alternativly when you set nobind openvpn will just pick a random unused port.
|
Hi, I'm not quite sure about the tests. Does this make sense for you as it is in the PR? Currently when testing server mode, it was not tested that the port number is actually in the file. So I just added nobind as default. Maybe it would make sense to define an additional test case with nobind false that has port xxx in the file. g |
luxflux
added a commit
that referenced
this pull request
May 12, 2015
feature (server): add nobind parameter support.
|
Thank you for your work! |
luxflux
added a commit
that referenced
this pull request
May 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server is running in client mode, you have to specify
a fixed port for every vpn server. Alternativly when you set nobind
openvpn will just pick a random unused port.