Earsdown/external ca support #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dh <%= @extca_dh_file %> | ||
| <% end -%> | ||
| <% unless @remote or !@crl_verify or !@extca_ca_crl_file -%> | ||
| crl-verify <%= @extca_ca_crl_file %> |
There was a problem hiding this comment.
There is already a crl-verify on https://github.com/luxflux/puppet-openvpn/pull/181/files#diff-802d2d256313233cb337adc27a84b4a4L23. I am pretty sure this will mess up something if it's specified twice.
|
Thank you for your work on this. When I investigated the Travis error, I found an issue which I marked with a comment. Could you address this one? Thank you! |
This was referenced Dec 27, 2015
Closed
|
@luxflux any updates on this? |
|
@earsdown @lendico-seong I added a review comment and the tests are failing. At the moment I don't have the time to dig into this and fix it by myself, so I'd appreciate if someone else can take care of it. |
|
This has been solved with #192 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I really liked the changes by @earsdown. I applied the requested fixes, so we can get this merged.
See #170 .