Merge pull request #61 from jadestorm/x_bit_support

X bit support

lib/puppet/provider/posix_acl/posixacl.rb

@@ -86,8 +86,11 @@ def permission=(_value) # TODO: Investigate why we're not using this parameter
       purge
     when :exact, :set
       cur_perm = permission
-      perm_to_set = @resource.value(:permission) - cur_perm
-      perm_to_unset = cur_perm - @resource.value(:permission)
+      # For comparison purposes, we want to change X to x as it's only useful
+      # for setfacl and isn't stored or noted by getfacl.
+      new_perm = @resource.value(:permission).map(&:downcase)
+      perm_to_set = new_perm - cur_perm
+      perm_to_unset = cur_perm - new_perm
       return false if perm_to_set.empty? && perm_to_unset.empty?
       # Take supplied perms literally, unset any existing perms which
       # are absent from ACLs given

lib/puppet/type/posix_acl.rb

@@ -1,5 +1,6 @@
 require 'set'
 require 'pathname'
+require 'English'
 
 Puppet::Type.newtype(:posix_acl) do
   desc <<-EOT
@@ -161,8 +162,10 @@ def unset_insync(cur_perm)
       (sp - cp).sort == sp
     end
 
+    # Make sure we are not misinterpreting recursive permission notation (e.g. rwX) when
+    # comparing current to new perms.
     def set_insync(cur_perm) # rubocop:disable Style/AccessorMethodName
-      should = @should.uniq.sort
+      should = @should.map(&:downcase).uniq.sort
       (cur_perm.sort == should) || (provider.check_set && (should - cur_perm).empty?)
     end
 
@@ -218,7 +221,7 @@ def insync?(is)
         s = p.tr '-', ''
         r << (s.sub!('r', '') ? 'r' : '-')
         r << (s.sub!('w', '') ? 'w' : '-')
-        r << (s.sub!('x', '') ? 'x' : '-')
+        r << (s.sub!(%r{x}i, '') ? $LAST_MATCH_INFO.to_s : '-')
         raise ArgumentError, %(Invalid permission set "#{p}".) unless s.empty?
       end
       r