Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use inspect instead of join to stringify arrays #27

Merged
merged 2 commits into from
Oct 4, 2016

Conversation

tequeter
Copy link

Less hand-coding and more readable for long ACLs, IMHO.

Before:

current_value , should be user:hrref:rwx,default:user:hrref:rwx,...

After:

current_value [], should be ["user:hrref:rwx", "default:user:hrref:rwx", ...

Less hand-coding and more readable for long ACLs, IMHO.

Before:
  current_value , should be user:hrref:rwx,default:user:hrref:rwx,...

After:
  current_value [], should be ["user:hrref:rwx", "default:user:hrref:rwx", ...
This makes it easier to compare changes in long ACLs.
@tequeter
Copy link
Author

Just as PR #28, the Travis build fails because of dependencies not compatible with old Ruby versions. This is unrelated to my PR AFAICT.

Gem::InstallError: rake requires Ruby version >= 1.9.3.
Gem::InstallError: json_pure requires Ruby version ~> 2.0.
etc.

@roidelapluie roidelapluie merged commit 76fafaf into voxpupuli:master Oct 4, 2016
@roidelapluie
Copy link
Member

Thanks!

@tequeter tequeter deleted the better-stringify branch October 13, 2016 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants