Normalize ACL's. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #4. |
Added munging of ACL's into the canonical format. The format from setfacl was used as a guide. With the exception that the type field can not be left out (defaults to user in setfacl). In general I tried to be strict. Here are some notes. - The type must be either the inital letter or the full type, nothing else is accepted. - The "who" field is not verified in any way. - The permssions field may only contain one of each 'r', 'w' and 'x' however the order is not checked. The only other character it can contain is '-' which is ignored. An octal digit is also accepted in which case it must be the only character.
|
This looks really good. I will test this as soon as I get a chance, may be a day or two. |
|
Awesome, I tried to test every branch so hopefully it checks out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added munging of ACL's into the canonical format. The format from
setfacl was used as a guide. With the exception that the type
field can not be left out (defaults to user in setfacl).
In general I tried to be strict. Here are some notes.
else is accepted.
however the order is not checked. The only other character it can
contain is '-' which is ignored. An octal digit is also accepted in
which case it must be the only character.