Implement handling of missing files #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jey @raemer, can you please rebase against our latest master branch? we did some work on the co pipeline. |
Hi, I rebased and fixed a few indentation/code unreachable warnings. |
If a ACL for a missing file was specified, the modules failed. This patch adds a parameter "ignore missing" that allows to specify the behavior: - raise an argument error (default) - quietly ignore this ACL - add a notice to the agent output and ignore the ACL
bastelfreak
force-pushed
the
add-ignore-missing
branch
from
af3429c
to
90d4447
Compare
|
@raemer thanks for the work. I rebased it again and will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull requests add a paramter (
ignore_missing) that allows controlling the behavior, if a path is not found on the target system. Currently, the modules fails at this point, as setfacl/getfacl fails.With the new parameter, this can be configured to fail with error (as now; default), issue a notice in the agent's output or silently ignore the error.
Use case example
In our use case, we want to allow a monitoring user to read git repos in order to determine if they are at a specific commit. To allow this, we add
u:monitoring:rxto the repo, via a hiera hash evaluated in a module present for each node. On some systems, this path may be missing (and is not monitored). We would like to be able to ignore this, as the repo also will not be checked.We do not implenent the ACL in the monitoring module, as there may be requirements to add further ACLs to the same path.