daemon: explicitly pass provider to service #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures puppet doesn't incorrectly detect the service provider in some circumstances (e.g. if a systemd unit is disabled). It also has the side-effect of enabling us to actually meaningfully override the provider (until now, setting $init_style would not propagate to the service, so puppet would try to detect the system provider even if you attempted to pass a different one) fixes voxpupuli#132
|
Thanks for this fix @costela! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
…rvice daemon: explicitly pass provider to service
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
…rvice daemon: explicitly pass provider to service
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures puppet doesn't incorrectly detect the service provider in some circumstances (e.g. if a systemd unit is disabled).
It also has the side-effect of enabling us to actually meaningfully override the provider (until now, setting $init_style would not propagate to the service, so puppet would try to detect the system provider even if you attempted to pass a different one)
fixes #132