Debian daemon template: Split and escape args to avoid quotes passed as args

[ntesteca]

Pull Request (PR) description

Split and escape args in the daemon template to avoid quotes passed as args to the exporter.
Tested with Debian 7 and apache, node, mysqld exporters.

This Pull Request (PR) fixes the following issue

Fixes #296

[bastelfreak]

@ntesteca thanks for providing this fix. Are you able to provide a test for this?

[ntesteca]

It looks like the test was already there but not used since Debian 7 is not supported anymore.

Before the fix:

PUPPET_INSTALL_TYPE=agent BEAKER_IS_PE=no BEAKER_PUPPET_COLLECTION=puppet5 BEAKER_debug=true BEAKER_setfile=debian7-64 BEAKER_HYPERVISOR=docker bundle exec rake beaker
...
Failures:

  1) prometheus apache exporter default install Process "apache_exporter" args should match /\ -scrape_uri http:\/\/localhost\/server-status\?auto/
     Failure/Error: its(:args) { is_expected.to match %r{\ -scrape_uri http://localhost/server-status\?auto} }
       expected "/usr/local/bin/apache_exporter -scrape_uri \"http://localhost/server-status?auto\"" to match /\ -scrape_uri http:\/\/localhost\/server-status\?auto/
       Diff:
       @@ -1,2 +1,2 @@
       -/\ -scrape_uri http:\/\/localhost\/server-status\?auto/
       +"/usr/local/bin/apache_exporter -scrape_uri \"http://localhost/server-status?auto\""
       
       
     # ./spec/acceptance/apache_exporter_spec.rb:25:in `block (4 levels) in <top (required)>'

  2) prometheus apache exporter apache_exporter update from 0.4.0 to 0.5.0 Process "apache_exporter" args should match /\ -scrape_uri http:\/\/localhost\/server-status\?auto/
     Failure/Error: its(:args) { is_expected.to match %r{\ -scrape_uri http://localhost/server-status\?auto} }
       expected "/usr/local/bin/apache_exporter -scrape_uri \"http://localhost/server-status?auto\"" to match /\ -scrape_uri http:\/\/localhost\/server-status\?auto/
       Diff:
       @@ -1,2 +1,2 @@
       -/\ -scrape_uri http:\/\/localhost\/server-status\?auto/
       +"/usr/local/bin/apache_exporter -scrape_uri \"http://localhost/server-status?auto\""
       
       
     # ./spec/acceptance/apache_exporter_spec.rb:43:in `block (4 levels) in <top (required)>'

  3) prometheus apache exporter apache_exporter update from 0.4.0 to 0.5.0 Process "apache_exporter" args should match /\ -scrape_uri http:\/\/localhost\/server-status\?auto/
     Failure/Error: its(:args) { is_expected.to match %r{\ -scrape_uri http://localhost/server-status\?auto} }
       expected "/usr/local/bin/apache_exporter -scrape_uri \"http://localhost/server-status?auto\"" to match /\ -scrape_uri http:\/\/localhost\/server-status\?auto/
       Diff:
       @@ -1,2 +1,2 @@
       -/\ -scrape_uri http:\/\/localhost\/server-status\?auto/
       +"/usr/local/bin/apache_exporter -scrape_uri \"http://localhost/server-status?auto\""
       
       
     # ./spec/acceptance/apache_exporter_spec.rb:62:in `block (4 levels) in <top (required)>'

...

• Failure stack before
• Failure stack after

[bastelfreak]

Hi.
I just noticed that the tests for Debian 8 and 9 passed. We don't support Debian 7 anymore. I rebased this PR and will merge it when travis turns green again.