Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alertmanager - Add flag for managing the config file #332

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

daniellawrence
Copy link

Pull Request (PR) description

Add new flag prometheus::alertmanager::manage_config for alertmanager.

This will give the user the option not have the prometheus::alertmanager::config_file managed by this module.

motivation for this change
We have a process outside of puppet that holds configuration information for alertmanager.

This Pull Request (PR) fixes the following issues

Not fixing an open issue, happy to open an issue for tracking if required.

This pull request is based on the work by @bastelfreak & @erilane in #319

@daniellawrence daniellawrence marked this pull request as ready for review July 11, 2019 07:30
@bastelfreak bastelfreak merged commit 4ccd209 into voxpupuli:master Jul 11, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants