add achive_bin_path parameter defaulting to existing value #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Mar 21, 2020
manifests/daemon.pp
Outdated
| @@ -67,6 +67,7 @@ | |||
| Hash[String, Scalar] $env_vars = {}, | |||
| Optional[String] $env_file_path = $prometheus::env_file_path, | |||
| Optional[String[1]] $extract_command = $prometheus::extract_command, | |||
| Stdlib::Absolutepath $achive_bin_path = "/opt/${name}-${version}.${os}-${arch}/${name}", | |||
There was a problem hiding this comment.
should this be archive_bin_path, and not achive..? Also please add a documentation for the param to the file.
robmbrooks
force-pushed
the
for-upstream
branch
from
ea2c3b5
to
85b1e81
Compare
|
@bastelfreak done and done, sorry, both of these should have been obvious |
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
add achive_bin_path parameter defaulting to existing value
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
this adds a parameter 'achive_bin_path' to the prometheus::daemon defined type
This Pull Request (PR) fixes the following issues
this is useful for frr_exporter as the archive binary is not in the expected location