Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extract_path to be modified #449

Merged
merged 1 commit into from
May 18, 2020

Conversation

treydock
Copy link

Pull Request (PR) description

Remove hardcoded extract_path. I ran into a few exporters where the binary is all that is extracted from tar.gz so necessary to create the extract path directory in profile then set this new parameter to that value.

Good example: https://github.com/ribbybibby/ssl_exporter/releases

@ghoneycutt
Copy link
Member

Thanks for the contribution! Could you please add a test of some kind for the new parameter.

@ghoneycutt ghoneycutt added enhancement New feature or request needs-tests labels May 18, 2020
@treydock
Copy link
Author

Added unit test for changing from the default value, the default value was already being tested.

@ghoneycutt
Copy link
Member

Tests are failing though I think it is unrelated. Seeing this in the travis output.

Error: /Stage[main]/Prometheus::Haproxy_exporter/Prometheus::Daemon[haproxy_exporter]/Archive[/tmp/haproxy_exporter-0.7.1.tar.gz]/ensure: change from 'absent' to 'present' failed: Execution of '/opt/puppetlabs/puppet/bin/curl https://github.com/prometheus/haproxy_exporter/releases/download/v0.7.1/haproxy_exporter-0.7.1.linux-amd64.tar.gz -o /tmp/haproxy_exporter-0.7.1.tar.gz_20200518-2581-dj4ovu -fsSLg --max-redirs 5' returned 22: curl: (22) The requested URL returned error: 429 too many requests

Perhaps travis needs a github token to get past that?

@ghoneycutt ghoneycutt merged commit 612b0db into voxpupuli:master May 18, 2020
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Jan 21, 2021
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants