support the new scrape_config_files option, prom ~v2.45 #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukebigum please update the REFERENCE.md (see https://voxpupuli.org/docs/how_to_run_tests/#referencemd-update) |
lukebigum
force-pushed
the
scrape_config_files
branch
from
d5b249d to
8d0a4d5
Compare
lukebigum
force-pushed
the
scrape_config_files
branch
2 times, most recently
from
70dcb26 to
e541729
Compare
|
Finally figured out what the REFERENCE.md check was. Helps if I read the test output. All green on this one @TheMeier. |
|
Can you also please add a short test for this new functionality |
lukebigum
force-pushed
the
scrape_config_files
branch
from
e541729 to
ba31b9b
Compare
|
... and some tests. :-) |
|
nice, thank you |
TheMeier
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds some config to support loading scrape configs from disk, rather than be included in the main prometheus.yml file. This option came in at about Prom version 2.45 IIRC. Since it's so new, took steps to try make it not appear anywhere unless it was requested (it'll make old Prom fail to load).
Happy to take some direction on how to test it better.