Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove code options for elasticsearch_exporter < 1.1.0 #804

Merged
merged 1 commit into from
Sep 4, 2024
Merged

remove code options for elasticsearch_exporter < 1.1.0 #804

merged 1 commit into from
Sep 4, 2024

Conversation

TheMeier
Copy link
Contributor

@TheMeier TheMeier commented Sep 4, 2024

fixes #786

bastelfreak
bastelfreak approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. should we leave this open some time to pile up more breaking changes?

@TheMeier
Copy link
Contributor Author

TheMeier commented Sep 4, 2024

There is already a breaking change merged and I was planing on finalizing https://github.com/voxpupuli/puppet-prometheus/milestone/3 soon

@bastelfreak bastelfreak merged commit b198386 into voxpupuli:master Sep 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for elasticsearch_exporter < 1.1.0
2 participants
@TheMeier @bastelfreak