Update options flag to new double dash format #816
Conversation
The nginx exporter logs the following deprecation warning after startup. ``` nginx-prometheus-exporter: the flag format is deprecated and will be removed in a future release, please use the new format: --nginx.scrape-uri ``` This PR intends to fix that deprecated format and use the current flag format with double dashes.
|
@lbdemv do you know since when the "--" versions are supported? |
|
Sorry, I didn't actually check that. I just saw it and went on to fix the current warning... Maybe I can dwell into that later today, if it is important. |
|
As i see that, the deprecation change is made in nginxinc/nginx-prometheus-exporter#460 The initial issue seem to be the change to kigpin in nginxinc/nginx-prometheus-exporter#420 which was flagged as a breaking change in the mentioned v1.0.0 changelog |
|
I see. The default version in this module is currently 0.11.0 (https://github.com/voxpupuli/puppet-prometheus/blob/master/manifests/nginx_prometheus_exporter.pp#L66) so we need a version comparision here. Also there is a pending MR (#783) to update the version but that needs some work :( |
Pull Request (PR) description
The nginx exporter logs the following deprecation warning after startup.
This PR intends to fix the deprecated flag format and use the current flag format with double dashes.
This Pull Request (PR) fixes the following issues
No issue opened so far.