Patch to support Centos 7 in bootstrap #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrapping currently repeats on every run due to the `creates => '/usr/local/bin/pip'` Centos 7(and possibly others) which place pip executable in /usr/bin/pip The repeated bootstrap needs to be patched to avoid nodes constantly grabbing the get_pip.py which includes a binary blob. This patching looks to have been attempted before but failed to include `path => ....` which would support finding `which` in any of those locations as well as allowing `which pip` to only look in the supplied path, basically extending our creates to support multiple locations of pip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Centos 7 Bootstrap loop, Issue #306
Bootstrapping currently repeats on every run due to the
creates => '/usr/local/bin/pip'Centos 7(and possibly others) which place pip executable in /usr/bin/pip
The repeated bootstrap needs to be patched to avoid nodes constantly grabbing the get_pip.py which includes a binary blob.
This patching looks to have been attempted before but failed to include
path => ....which would support findingwhichin any of those locations as well as allowingwhich pipto only look in the supplied path, basically extending our creates to support multiple locations of pip.