Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu 18.04 support #426

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Add ubuntu 18.04 support #426

merged 2 commits into from
Aug 29, 2018

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Aug 23, 2018

Pull Request (PR) description

I know theres no vagrant image yet (created ticket: see below), but i figured it might be nice to at least run the tests in travis. Not sure if you want to claim that as "supported", but I figured it was a start.

https://tickets.puppetlabs.com/browse/IMAGES-913

This Pull Request (PR) fixes the following issues

Partially fixes #399
This issue should probably stay open until acceptance tests are added, but this is a start to certifying with 18.04.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We manage .travis.yml via .sync.yml with modulesync. Could you update that as well so we don't overwrite it on the next update?

@bastelfreak
Copy link
Member

@danquack FYI there are already acceptance tests: https://github.com/voxpupuli/puppet-python/tree/master/spec/acceptance

As soon as you add ubuntu 18.04 to .sync.yml we can merge this.

@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Aug 29, 2018
@danquack
Copy link
Contributor Author

@bastelfreak, I can most certainly add that to the sync file. What I was bringing up, was there’s no nodeset for Ubuntu 18, although this does run it through Travis.

@bastelfreak
Copy link
Member

A nodeset is not required anymore. They are generated by BEAKER_setfile=ubuntu1804-64{hypervisor=docker}.

@danquack
Copy link
Contributor Author

Is it something worth removing all together in a separate PR?

@bastelfreak
Copy link
Member

Our nodesets come from https://github.com/voxpupuli/modulesync_config/tree/master/moduleroot/spec/acceptance/nodesets. I did not test the generator for anything except docker nodesets. If you want you can open an issue on https://github.com/voxpupuli/modulesync_config to discuss the removal. We already purged all the docker nodesets.

@bastelfreak bastelfreak changed the title Added ubuntu 18.04 to travis tests Add ubuntu 18.04 support Aug 29, 2018
@bastelfreak bastelfreak removed the needs-work not ready to merge just yet label Aug 29, 2018
@bastelfreak bastelfreak merged commit 2a6ce18 into voxpupuli:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ubuntu 18.04 support
3 participants