Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added management of scm-import.properties #193

Merged
merged 3 commits into from
Mar 8, 2016
Merged

Added management of scm-import.properties #193

merged 3 commits into from
Mar 8, 2016

Conversation

dalisch
Copy link
Contributor

@dalisch dalisch commented Mar 7, 2016

Overview

  • added management of scm-import.properties files via hiera, which is used by Rundeck SCM for project jobs; does not (yet) execute the 'git clone' which actually retrieves the jobs onto the Rundeck server
  • fixed some ambiguity in tests for file_keystore_spec.rb

Tests

Example Hiera structure

rundeck::projects:
  my_project:
    scm_import_properties:
      scm.import.config.useFilePattern: true
      scm.import.config.strictHostKeyChecking: 'no'
      scm.import.config.filePattern: 'proect_1/*'
      scm.import.config.url: 'https\://github.com/rundeck/rundeck-jobs-test.git'
      scm.import.config.format: yaml
      scm.import.config.dir: /var/lib/rundeck/projects/my_project/scm
      scm.import.config.pathTemplate: '${job.project}/${job.group}${job.name}-${job.id}.${config.format}'
      scm.import.config.sshPrivateKeyPath: ''
      scm.import.config.gitPasswordPath: ''
      scm.import.config.branch: master
      scm.import.enabled: false
      scm.import.roles.0: user
      scm.import.type: git-import
      scm.import.username: ''
      scm.import.roles.count: 1
      scm.import.trackedItems.count: 0

… ambiguity in tests for file_keystore_spec.rb
@jyaworski
Copy link
Member

You opened this PR at the perfectly wrong time. Please rebase after #194 is merged.

jyaworski added a commit that referenced this pull request Mar 8, 2016
Added management of scm-import.properties
@jyaworski jyaworski merged commit 596bcd8 into voxpupuli:master Mar 8, 2016
@dalisch dalisch deleted the manage_scm_import_properties branch March 8, 2016 16:49
@dalisch
Copy link
Contributor Author

dalisch commented Mar 8, 2016

thanks @jyaworski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants