Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CentOS 5 support #190

Closed
vinzent opened this issue Jan 30, 2017 · 6 comments
Closed

Remove CentOS 5 support #190

vinzent opened this issue Jan 30, 2017 · 6 comments
Labels
backwards-incompatible
Milestone
1.0.0

Comments

@vinzent
Copy link
Contributor

vinzent commented Jan 30, 2017

just tried to run the acceptance test for centos5.

  • selinux::module fails (could not find /usr/share/selinux/devel/Makefile)
  • selinux::permissive fails (semanage permissive doesn't exist at all)

CentOS 5 will be out of support on 2015-03 so I don't think its worth to invest time.

my proposed solution is to just remove Centos 5 support from metadata.json.
@vinzent vinzent mentioned this issue Jan 30, 2017
Merged
@vinzent
Copy link
Contributor Author

vinzent commented Jan 30, 2017

legacy fedora releases should be removed too (Fedora 19-23) from metadata.json

@vinzent vinzent added this to the 1.0.0 milestone Jan 30, 2017
@juniorsysadmin
Copy link
Member

juniorsysadmin commented Jan 30, 2017 •
edited
Loading

Fedora version strings probably shouldn't be in the metadata.json

@vinzent
Copy link
Contributor Author

vinzent commented Jan 31, 2017 via email

@vinzent
Copy link
Contributor Author

vinzent commented Jan 31, 2017

I think we should list what we are running beaker acceptance tests for.

@oranenj
Copy link
Contributor

oranenj commented Jan 31, 2017

I think it makes sense to support at least:

  • CentOS/RHEL 6 (latest minor release, and the others best-effort only) and 7.3, and additionally RHEL 7.2 (CentOS doesn't usually support point releases after the next one is released AFAIK, but RHEL does, and not everyone will have updated to 7.3)
  • Fedora 24 and 25

@oranenj
Copy link
Contributor

oranenj commented Jan 31, 2017

I'm not sure if there are boxes available for testing against RHEL, but CentOS probably is close enough.

@vinzent vinzent mentioned this issue Jan 31, 2017
Merged
EmRowlands pushed a commit to EmRowlands/puppet-selinux that referenced this issue Mar 29, 2023
@vinzent
Remove support for EL5 and Fedora < 24
3d1f034 
We only can run acceptance tests against supported upstream distros.

Right now our acceptance tests run on:

* CentOS 6, 7 (compatible with RHEL 6, 7)
* Fedora 24, 25

The module stated support for CentOS 5 but actually it didn't work.

Closes voxpupuli#190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@oranenj @vinzent @juniorsysadmin