Fixes Issue-104 - No Hiera support #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiera hash are managed only if they exist + hiera lookups outside of the variables part of the manifest.
Closed
|
Multiples commit are due to the fact I don't have ssh access to GitHub from my office => I commit from GitHub WebUI directly. |
jyaworski
reviewed
Nov 6, 2016
| $selinux_booleans = hiera('selinux_booleans', undef) | ||
| $selinux_modules = hiera('selinux_modules', undef) | ||
| $selinux_fcontexts = hiera('selinux_fcontexts', undef) | ||
| $selinux_ports = hiera('selinux_ports', undef) |
There was a problem hiding this comment.
Should these all be prefixed with selinux:: in the hiera key?
There was a problem hiding this comment.
You are right (I didn't check it in the README file)
By the way, I also forgot the permissive defined type which I just added.
There was a problem hiding this comment.
I still can use Git only through the GitHub WebUI.
That's the reason of the multiple commits and useless lints.
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
* Fixes Issue-104 - No Hiera support Hiera hash are managed only if they exist + hiera lookups outside of the variables part of the manifest. * Puppet lint fix https://travis-ci.org/voxpupuli/puppet-selinux/jobs/173201284 * Another lint fix * Fix following @jyaworski comment * Puppet lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiera hash are managed only if they exist