Fixing change-selinux-status-to-disabled exec #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have unfortunately no idea why the checks fail. Why can't Travis load bundle? |
|
@bjvrielink i'llr rerun the travis jobs |
|
I'm currently doing a modulesync, this will hopefully fix the travis issues. |
Merged
|
@bjvrielink can you rebase please? |
bjvrielink
force-pushed
the
setenforce_fix
branch
from
d64743d to
1a3b767
Compare
|
Rebased. I'm new to Travis, so no idea why it is taking so long... |
setenforce only accepts enforcing or permissive (or 0 and 1) as possible modes. When calling the selinux module with the current mode as either enforcing or permissive and $mode => disabled, the exec change-selinux-status-to-disabled will give exit code 1. A reboot does solve this, but until that happens. each puppet run will result in a report with a corrective change.
bjvrielink
force-pushed
the
setenforce_fix
branch
from
1a3b767 to
b9b1db6
Compare
|
Travis limits on the number of jobs. It's queued though so we'll just have to be patient. |
weaselshit
pushed a commit
to weaselshit/puppet-selinux
that referenced
this pull request
Jan 11, 2018
The voxpupuli#245 issue was addressed by voxpupuli#246, but that introduced a new problem: when mode param is set to 'disabled', runtime mode never gets changed to 'permissive' anymore. The original problem was different: it was not wrong parameter to setenforce, instead, the unless command was wrong, always grepping for 'disabled|disabled'. This change uses literal modes instead of numeric for both exec *and* unless command and removes conditinal statement added in voxpupuli#246 to restore original behaviour. It also adds tests for unless param of the exec in question.
weaselshit
added a commit
to weaselshit/puppet-selinux
that referenced
this pull request
Jan 11, 2018
The voxpupuli#245 issue was addressed by voxpupuli#246, but that introduced a new problem: when mode param is set to 'disabled', runtime mode never gets changed to 'permissive' anymore. The original problem was different: it was not wrong parameter to setenforce, instead, the unless command was wrong, always grepping for 'disabled|disabled'. This change uses literal modes instead of numeric for both exec *and* unless command and removes conditinal statement added in voxpupuli#246 to restore original behaviour. It also adds tests for unless param of the exec in question.
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
Fixing change-selinux-status-to-disabled exec
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
The voxpupuli#245 issue was addressed by voxpupuli#246, but that introduced a new problem: when mode param is set to 'disabled', runtime mode never gets changed to 'permissive' anymore. The original problem was different: it was not wrong parameter to setenforce, instead, the unless command was wrong, always grepping for 'disabled|disabled'. This change uses literal modes instead of numeric for both exec *and* unless command and removes conditinal statement added in voxpupuli#246 to restore original behaviour. It also adds tests for unless param of the exec in question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setenforce only accepts enforcing or permissive (or 0 and 1) as possible modes.
When calling the selinux module with the current mode as either enforcing or permissive and $mode => disabled, the exec change-selinux-status-to-disabled will give exit code 1. A reboot does solve this, but until that happens. each puppet run will result in a report with a corrective change.