Add support for installing pre-compiled policy packages #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinzent
approved these changes
Mar 20, 2018
There was a problem hiding this comment.
overall looks good to me.
The problem i see with binary policies is that for example a binary policy on compiled on EL6 can't be installed on EL7 and vice versa. Even a EL 7.4 compiled module maybe can't be installed on a EL7.3 system. Also makes it not so easy to create beaker acceptance tests.
|
@vinzent should that be added to the README.md? |
|
@oranenj can you check the rubocop error? |
|
I thought I fixed up rubocop errors :| I'm unfortunately a bit busy at the moment, but I'll try to look at this early next week. |
|
Bleh, I've been way too busy. Just now remembered to run that rubocop. :) |
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
Add support for installing pre-compiled policy packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying a source for a precompiled policy package in the
selinux::moduledefined type.Currently mostly untested, but I'm submitting this here for review anyway. I intend to test it later today or tomorrow if I don't have time today.