Skip to content

Commit

Permalink
Raise warning if hiera check is called but disabled
Browse files Browse the repository at this point in the history
Previously we got the following output from the `syntax` rake task:

```terminal
$ bundle exec rake syntax
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
```

This is a bit misleading because the `syntax:hiera:yaml` task was indeed
called, but it doesn't do anything because
`PuppetSyntax.check_hiera_keys` was false. With this commit the output
changes:

```terminal
$ bundle exec rake syntax---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
syntax:hiera:yaml was called, but PuppetSyntax.check_hiera_keys is false. hiera syntax won't be checked
```
  • Loading branch information
bastelfreak committed Mar 8, 2024
1 parent 2c1b8fa commit b9d7b46
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/puppet-syntax/tasks/puppet-syntax.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def filelist_hiera_yaml
end

def initialize(*_args)
desc 'Syntax check Puppet manifests and templates'
desc 'Syntax check for Puppet manifests, templates and Hiera'
task syntax: [
'syntax:manifests',
'syntax:templates',
Expand Down Expand Up @@ -69,6 +69,7 @@ def initialize(*_args)
namespace :hiera do
task :yaml do |t|
warn "---> #{t.name}"
warn "#{t.name} was called, but PuppetSyntax.check_hiera_keys is false. hiera syntax won't be checked" unless PuppetSyntax.check_hiera_keys
c = PuppetSyntax::Hiera.new
errors = c.check(filelist_hiera_yaml)
$stdout.puts "#{errors.join("\n")}\n" unless errors.empty?
Expand Down

0 comments on commit b9d7b46

Please sign in to comment.