Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a too greedy regular expression for
rake syntax:hiera
.Description:
Given these keys in a common.yaml:
This concatenates the keys 'firstkey' ('one') and 'secondkey' ('two') to 'mykey' ('onetwo').
Because of a too greedy regular expression, this leads to a warning, which shouldn't.
Expected result:
Actual result:
Explanation:
The regular expression
/%{.+\('.*'\).+}/
matches%{lookup('firstkey')}%{lookup('secondkey')}
, which fires the Warning.The regular expression
/%{[^}]+\('[^}]*'\)[^}\s]+}/
does not match%{lookup('firstkey')}%{lookup('secondkey')}
.It still matches
%{lookup('firstkey'):3306}%{lookup('secondkey')}
or any other non-whitespace character between)
and the next}
in a function interpolation, which is the purpose of the Warning.