Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require puppetlabs/stdlib 9 #52

Merged
merged 3 commits into from
Jul 13, 2023
Merged

require puppetlabs/stdlib 9 #52

merged 3 commits into from
Jul 13, 2023

Conversation

robertc99
Copy link

Pull Request (PR) description

ensure compatability with latest stdlib

This Pull Request (PR) fixes the following issues

n/a

@bastelfreak
Copy link
Member

@robertc99 please update spec/spec_helper_acceptance.rb to allow newer versions of apache/java modules. We also need to wait until a newer version of puppetlabs/java is released.

@robertc99
Copy link
Author

I updated spec/spec_helper_acceptance.rb as requested.
Its still failing the check, but the error makes no sense to me.

@bastelfreak
Copy link
Member

@robertc99 the problem is that the latest version of puppetlabs/java doesn't allow puppetlabs/stdlib 9. We need to wait for a new release.

@robertc99
Copy link
Author

ok, the repo head has been updated. they just need to do a release.

@robertc99
Copy link
Author

looks like a new java has been released. how do I get it to redo the checks?

@bastelfreak
Copy link
Member

mhm I'm currently not sure why this fails 🤔 . I asked on slack.

@bastelfreak
Copy link
Member

It's failing because latest apache doesn't allow latest concat. and older concat don't allow latest stdlib. I raised puppetlabs/puppetlabs-apache#2426

@robertc99
Copy link
Author

looks like the apache bit is done

@robertc99
Copy link
Author

can you force the checks to rerun?

@bastelfreak bastelfreak reopened this Jul 13, 2023
@bastelfreak bastelfreak changed the title stdlib 9 compat require puppetlabs/stdlib 9 Jul 13, 2023
@bastelfreak bastelfreak merged commit a8b2747 into voxpupuli:master Jul 13, 2023
@robertc99
Copy link
Author

thanks.
now we just need a release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants