-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require puppetlabs/stdlib 9 #52
Conversation
@robertc99 please update spec/spec_helper_acceptance.rb to allow newer versions of apache/java modules. We also need to wait until a newer version of puppetlabs/java is released. |
I updated spec/spec_helper_acceptance.rb as requested. |
@robertc99 the problem is that the latest version of puppetlabs/java doesn't allow puppetlabs/stdlib 9. We need to wait for a new release. |
ok, the repo head has been updated. they just need to do a release. |
looks like a new java has been released. how do I get it to redo the checks? |
mhm I'm currently not sure why this fails 🤔 . I asked on slack. |
It's failing because latest apache doesn't allow latest concat. and older concat don't allow latest stdlib. I raised puppetlabs/puppetlabs-apache#2426 |
looks like the apache bit is done |
can you force the checks to rerun? |
thanks. |
Pull Request (PR) description
ensure compatability with latest stdlib
This Pull Request (PR) fixes the following issues
n/a