Remove fastestmirror_enabled and report_instanceid parameters #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…azon Linux repo defaults as they are unsupported by puppet
juniorsysadmin
approved these changes
Jun 6, 2018
|
Thanks for the PR @Zordrak ! @juniorsysadmin I'm not sure if this is breaking change, if we consider the current code as broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Remove the Amazon Linux default repository parameters fastestmirror_enabled and report_instanceid.
While report_instanceid is functional, fastestmirror_enabled is not functional. Neither parameter is supported by the Puppet Yumrepo type.
Puppetlabs has been approached (in https://tickets.puppetlabs.com/browse/PUP-8730) to add support for these parameters, however a decision has been made not to do this and instead to modify the Yumrepo type in Puppet 6 to allow for arbitrary parameters (https://tickets.puppetlabs.com/browse/PUP-8904).
Until such time as this issue is addressed in Puppet it is not possible to define these parameters to maintain parity with upstream and therefore they should be removed from this module. Otherwise the Default OS Repo functionality for Amazon Linux in this module cannot work at all.
This Pull Request (PR) fixes the following issues
Fixes #100