Puppet 6 issue and knockout_prefix problem #121
Conversation
|
I was able to bypass that when prefixing in my hiera file the yum::gpgkeys with "---" just above. Do we have an ETA on this PR being merged and a new version release @bastelfreak ? |
| @@ -216,7 +216,7 @@ | |||
| true => '--keepdevel', | |||
| default => undef, | |||
| }, | |||
| ]) | |||
| ].filter |$val| { $val =~ NotUndef } | |||
There was a problem hiding this comment.
oh nice, I didn't know that NotUndef is a thing!
There was a problem hiding this comment.
er, maybe I am just mis-reading this, but wouldn't it have been easier to just set the default for $keep_kernel_devel to '' (empty string)? That is the only potentially undefined value there, right?
|
Hi, thanks for the PR.I'm not sure if this a breaking change or not. Could you explain a bit in which setup the old code break? Could you provide this as an acceptance test? |
|
The delete_undef_values code broke in an earlier version of Puppet 6--it looks like it was addressed in a later release. However, the knockout_prefix issue is still a problem. I'll try to find some time to update the PR. |
|
I'm facing the same issue by simply using the yum module without any configuration on a clean centos7 system. The patch from @bastelfreak fixes the issue. |
|
I am glad you have this fixed already, cause I was just about to dig into this one, and it was making me dizzy already. :) |
bastelfreak
added
bug
|
Great! :-) Shouldn't this warrant a release? I don't mind patching locally, but it'd be easier to upgrade the module since Puppet 6 still acts up with 3.1.1. |
|
PR #121 may have been merged on 3/16/2019 but no new release tags have been published since then. Version 3.1.1 is still the latest tagged release and it does not include the gpgkeys knockout prefix fix. |
|
I'm doing a new release at #134 |
|
Thanks, that fixed it.
David Goldsmith
From: Tim Meusel <notifications@github.com>
Reply-To: voxpupuli/puppet-yum <reply@reply.github.com>
Date: Tuesday, May 7, 2019 at 2:48 PM
To: voxpupuli/puppet-yum <puppet-yum@noreply.github.com>
Cc: David Goldsmith <DGoldsmith@sans.org>, Comment <comment@noreply.github.com>
Subject: Re: [voxpupuli/puppet-yum] Puppet 6 issue and knockout_prefix problem (#121)
I'm doing a new release at #134<#134>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#121 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABT6XGGVPJ734Q6RBAP5GMDPUHFHLANCNFSM4FYJ7PQA>.
|
Pull Request (PR) description
This Pull Request (PR) fixes the following issues