Correctly calculate rpmname for all gpg versions

[towo]

Pull Request (PR) description

ensure => present for yum::gpgkey is inconsistent with newer versions of GPG (presumably starting with 2.2, but I have a limited sample size). Change has occured between 2.0.9 and 2.2.5.

Observed behaviour

GPG >2.2 (?)

hawking:~ # gpg --version
gpg (GnuPG) 2.2.5
libgcrypt 1.8.2
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: /root/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
        CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2

Current method:

hawking:~ # gpg /etc/pki/rpm-gpg/Puppet.key 2>/dev/null | head -1
pub   rsa4096 2016-08-18 [SC] [expires: 2021-08-17]

Proposed method:

hawking:~ # gpg --with-colons /etc/pki/rpm-gpg/Puppet.key 2>/dev/null | head -n 1 | cut -d: -f5
7F438280EF8D349F

GPG < 2.2

kepler:~ # gpg --version
gpg (GnuPG) 2.0.9
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: ~/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA
Cipher: 3DES, CAST5, BLOWFISH, AES, AES192, AES256,

Current method:

kepler:~ # gpg /etc/pki/rpm-gpg/Puppet.key
pub  4096R/EF8D349F 2016-08-18 Puppet, Inc. Release Key (Puppet, Inc. Release Key) <release@puppet.com>

Proposed method:

kepler:~ # gpg --with-colons /etc/pki/rpm-gpg/Puppet.key 2>/dev/null | head -n 1 | cut -d: -f5
7F438280EF8D349F

This Pull Request (PR) fixes the following issues

Fixes #125

[bastelfreak]

Thanks for the spec tests. Can you please have a look at the rubocop issue?

[towo]

There, all good now.