-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'VirtuozzoLinux' support #147
Conversation
b531435
to
008151d
Compare
data/os/RedHat/VirtuozzoLinux.yaml
Outdated
# VirtuozzoLinux default repos for AWS. | ||
--- | ||
yum::os_default_repos: | ||
- "rhui-REGION-rhel-server-releases" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have a look at the CentOS.yaml? I think the default repositories here are not correct for VirtuozzoLinux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-checked init.pp
. To my understanding, these files would only be necessary if someone uses manage_os_default_repos = true
. This would not work with the current version of this module. So I'd expect noone is actually using this.
If this is correct, implementing correct VirtuozzoLinux.yaml
. VirtuozzoLinux/6.yaml
, and VirtuozzoLinux/7.yaml
would not be worth the time.
(I tried it. 6 and 7 only share two repo file names, everything else is different)
008151d
to
ce6f0c2
Compare
If you would like help on where to put the data, please post the contents of the default yum.repos.d files from each OS. Leaving the data out entirely is better than having it wrong, but if possible, it should be populated. IMO |
VirtuozzoLinux 7
|
VirtuozzoLinux 6
|
So, they are really close to being the same, but it is not simply 6 vs 7. The base repo name is different (although that wouldn't be too hard to work around), and the server name is different, but they are actually the same host.
So, it is very much like the CentOS configuration (more like CentOS than RHEL). You can probably put each list of repos into the You basically should be able to (re)move all the files in /etc/yum.repos.d and puppet should create them and end up with the same end state (note that the yum type will actually create one file (xyz.repo) instead of putting them all into virtuozzo.repo, but the end result is the same. ~tommy PS: More importantly, some people (me) like to purge any unmanaged repos, so having a list of OS defaults is a "good thing" if you are going to add that to the supported list. :) |
ce6f0c2
to
477c94c
Compare
|
477c94c
to
020ba83
Compare
I've added all default repositories, but haven't tried de-duplicating anything. Does anyone have suggestions regarding de-duplication? Or is it ok the way it is as the data is not expected to change ever again. |
I've added tests, too. Now Travis shouldn't be failing anymore. Can someone please have a look? |
e74062e
to
daa619e
Compare
daa619e
to
791d55f
Compare
facter
3.14 adds support foros.name
VirtuozzoLinux (https://puppet.com/docs/puppet/latest/release_notes_facter.html). This meansos.name
won't resolve to RedHat anymore.