Comma separated values for assumeyes #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @matonb , thanks for the PR. Can you take a look at the failed spec tests? |
|
@bastelfreak Sure, Oh the joys of ruby versions... |
Add String to $ensure varaiant types. Add spec test for comma separated strings.
|
Fixed, I did need to add String to the variant type for ensure to get the new comma test to work. I normally just run Seeing |
|
thanks! |
bastelfreak
changed the title
|
@bastelfreak Cool, any idea when it'll get bagged and tagged so I can stop pointing at my fork ? |
|
I just pushed a new release |
|
@bastelfreak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping
$ensurein single quotes allows comma separated values.#21