allow RpmNameGlob for versionlock entries #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in the manpage [1] yum versionlock supports package-wildcard and does not require exact matches for package-names. The following is valid `versionlock.list` content: ``` libvirt*-0:7.6.0-*.* qemu*-0:6.1.0-*.* ``` This commit swaps `Yum::RpmName` with `Yum::RpmNameGlob` for the versionlock `assert_type()` and thus allowing the above mentioned examples. [1] https://man7.org/linux/man-pages/man1/yum-versionlock.1.html
|
Example: |
vchepkov
reviewed
Aug 22, 2024
There was a problem hiding this comment.
IMHO, you need to use --raw switch, otherwise dnf versionlock (totally different format) would require you to use NEVRA
https://dnf-plugins-core.readthedocs.io/en/latest/versionlock.html
PS. Since we edit file directly, it doesn't matter
vchepkov
approved these changes
Aug 22, 2024
|
@vchepkov Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased @foxxx0 commit against master (see #228)
We're using his feature branch internally with RHEL 8 and RHEL 9 for about 2 years.
As stated in the manpage [1] yum versionlock supports package-wildcard
and does not require exact matches for package-names.
The following is valid
versionlock.listcontent:This commit swaps
Yum::RpmNamewithYum::RpmNameGlobfor theversionlock
assert_type()and thus allowing the above mentionedexamples.
[1] https://man7.org/linux/man-pages/man1/yum-versionlock.1.html