Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical facts don't get filtered properly #612

Closed
mike406 opened this issue Mar 2, 2021 · 1 comment · Fixed by #647
Closed

Numerical facts don't get filtered properly #612

mike406 opened this issue Mar 2, 2021 · 1 comment · Fixed by #647
Labels

Comments

@mike406
Copy link

mike406 commented Mar 2, 2021

I noticed an issue with trying to filter numeric facts. For example I need to track version upgrades for our 600 Windows 10 PCs so I use the /fact/windows_release_id fact. If I want to view version 1909 for example, I would put /fact/windows_release_id/1909. However when I do this, it shows me all Windows 10's regardless of version number. I instead have to use the search box and type in "1909" to get the filter I need.

@gdubicki gdubicki added the bug label Nov 21, 2021
gdubicki added a commit that referenced this issue Nov 29, 2021
and extend the width of the fact values column in the node
view as the values are usually longer that the names.
Thus this implements #83.

Also fix getting nodes with non-string fact values (#612):
Examples:
* int (in this case the filtering did not occur at all
  and ALL results were returned),
* list of dict (here the filtering was not done and
  ZERO results were returned),

As showing fact values does not use the code that strips
trailing 'u' anymore, this also fixes #567.
gdubicki added a commit that referenced this issue Nov 29, 2021
and extend the width of the fact values column in the node
view as the values are usually longer that the names.
Thus this implements #83.

Also fix getting nodes with non-string fact values (#612):
Examples:
* int (in this case the filtering did not occur at all
  and ALL results were returned),
* list of dict (here the filtering was not done and
  ZERO results were returned),

As showing fact values does not use the code that strips
trailing 'u' anymore, this also fixes #567.
@gdubicki
Copy link
Contributor

Fixed in v3.3.0 released today. Please check it out @mike406 . :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants