Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tabs for disabled features #627

Closed
nick-markowski opened this issue Jul 13, 2021 · 3 comments
Closed

Remove tabs for disabled features #627

nick-markowski opened this issue Jul 13, 2021 · 3 comments
Assignees
@sebastianrakel
Labels
skip-changelog

Comments

@nick-markowski
Copy link

Setting ENABLE_QUERY, ENABLE_CATALOG to False should remove the Query and Catalogs tabs, respectively.

Presently, the Query and Catalogs tabs persist when their respective features are disabled, and accessing the tab results in a 'Forbidden' page. Experienced on Puppetboard v3.1.0
sebastianrakel added a commit to sebastianrakel/puppetboard that referenced this issue Oct 4, 2021
@sebastianrakel
Remove menu entry if feature is disabled
875342c 
Use function to resolve menu entries, which are enabled

This should resolve issue voxpupuli#627
@sebastianrakel sebastianrakel mentioned this issue Oct 4, 2021
Merged
@sebastianrakel sebastianrakel self-assigned this Oct 4, 2021
@sebastianrakel
Copy link
Member

Hey, i provided a PR with changes that should fix it

@sebastianrakel sebastianrakel mentioned this issue Oct 4, 2021
Closed
sebastianrakel added a commit to sebastianrakel/puppetboard that referenced this issue Oct 4, 2021
@sebastianrakel
Fix issue voxpupuli#627 (really!) and resulting issue voxpupuli#635
d879ab7
gdubicki added a commit that referenced this issue Oct 4, 2021
@gdubicki
Merge pull request #636 from sebastianrakel/fix-issue-635
76d4057 
Fix issue #627 (really!) and resulting issue #635
@gdubicki
Copy link
Contributor

Released in v3.2.0 today. :)

@nick-markowski
Copy link
Author

@sebastianrakel @gdubicki thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianrakel sebastianrakel

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bastelfreak @gdubicki @sebastianrakel @nick-markowski