Remove border-radius from Top Menu #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 85.95% 85.95%
=======================================
Files 19 19
Lines 1061 1061
=======================================
Hits 912 912
Misses 149 149 Continue to review full report at Codecov.
|
|
Thanks for the contribution @promarcel! It does look better without those rounded corners. 😊 |
|
Oops, I forgot to mention you in the release that included your contribution, sorry for that! I have fixed it now, please check out the v4.0.1 changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a user experience perspective, it would make sense to remove the
border-radiuswhich is added bysemantic.min.cssand thus make the top navigation appear more clearly anchored to the page.