-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Server support in metadata.json #42
Comments
It's possible this may need filed against facterdb, just let me know and I can create one there. |
rspec-puppet-facts currently doesn't quite work when testing against Windows servers: voxpupuli/rspec-puppet-facts#42 Because of that, we now specifically set the os['family'] fact and test on that. Prior to this, the spec test wasn't running against an example Windows server at all.
For the next person - the only windows facts supported at the moment are
|
voxpupuli/facterdb#46 added a lot more supported windows platforms, and was released already. @rnelson0 does that clear up your problem? |
@DavidS Unfortunately, no. The issue is either normalizing the release string, e.g. "2012 R2" and "Server 2012 R2", or fixing any puppetlabs modules that reference the wrong string. For example, here's an rspec test that says
With the string
With
It's pretty clear that the I guess I'm also looking for a ruling because it would be nice to updated metadata-json-lint to throw warning/errors on it, which is something the Forge could then use to help authors ensure their Compatibility flags are correct - but only if |
IMHO the |
OK, if there's no normalization then I'll open a modules ticket against stdlib and try and an issue on metadata-json-lint to notify about this. |
It appears that the proper way to support Windows variants in
metadata.json
, looking at a few puppetlabs examples, is with a stringServer <version>[ <release>]
, e.g.Server 2012 R2
. However, this does not result in the OS being added to theon_supported_os
hash. Instead, the string2012 R2
needs to be used.Which is correct, and is there a way to normalize that so either string would pick up the
windows-2012-r2
collections in facterdb?The text was updated successfully, but these errors were encountered: